Adding settings for using @src as an import alias #116
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
jacobo-dominguez-wgu
requested review from
arbrandes,
brian-smith-tcril and
holaontiveros
diana-villalvazo-wgu
added
the
mao-onboarding
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
It seems there's a package.json version change that shouldn't be here, but otherwise, looks good to me! Thanks!
| { | ||
| "name": "@openedx/frontend-base", | ||
| "version": "1.0.0-alpha.7", | ||
| "version": "1.0.0-alpha.8", |
There was a problem hiding this comment.
This is already in main... no? Weird that it's even showing up here.
There was a problem hiding this comment.
Yes it is
What do you mean? That you also need to add the |
Like in here https://github.com/openedx/frontend-app-instruct/pull/80/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0, it is needed to add the |
4 participants
Description
This pr adds the @src import alias to avoid using
../.to import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead of from'../../../../testUtils'Updates all the webpack config files, tsconfigs and jest config files with the
@srcalias, even tho the client project still needs to override the tsconfig since it is not being reflected properly (any idea why?)Fixes parts of openedx/frontend-app-instruct#76
Tested on the instructor dashboard mfe and works fine.